Improve pipeline stages ast errors. #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They would throw 500 instead of 4xx before. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
kavirajk
reviewed
Oct 26, 2020
|
|
||
| // IsParseError returns true if the err is a ast parsing error. | ||
| func IsParseError(err error) bool { | ||
| _, ok := err.(ParseError) |
There was a problem hiding this comment.
we could use new errors.Is api :)
https://golang.org/pkg/errors/#Is
Two advantages:
- avoid type assertion
- can also be wrapped errors!
There was a problem hiding this comment.
Definitively a good idea. I would prefer to keep this for another PR I'm chasing after a bug for 2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They would throw 500 instead of 4xx before.
/cc thanks @owen-d for finding it.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com